k3nny
e931b9d1c9
Four correctness fixes to the GitLab CI expression parser in
internal/cicontext/eval.go:
- Multi-line: \n and \r are now treated as whitespace in skipWS so
block-scalar or folded-scalar if: values with || / && on continuation
lines evaluate correctly instead of falling back to permissive true.
- ${VAR} curly-brace variable syntax now supported in parseValue.
- Regex flags (/pattern/i, /pattern/m, /pattern/s) are now consumed and
translated to Go (?i)/(?m)/(?s) prefixes via applyRegexFlags.
- Variable on RHS of =~ / !~: when the right operand is $VAR, the
variable's value is interpreted as a /regex/[flags] string via
extractRegexFromString; non-regex values fall back to permissive true.
Adds 16 new unit tests covering all four cases and a testdata fixture
(rules_if_expr.yml) exercising multi-line, ${VAR}, and /pattern/i in a
real pipeline with context flags.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
120 lines
7.1 KiB
Go
120 lines
7.1 KiB
Go
package cicontext
|
|
|
|
import "testing"
|
|
|
|
func TestEvalIf(t *testing.T) {
|
|
vars := func(key string) string {
|
|
m := map[string]string{
|
|
"CI_COMMIT_BRANCH": "develop",
|
|
"CI_COMMIT_TAG": "",
|
|
"CI_PIPELINE_SOURCE": "push",
|
|
"DEPLOY_ENV": "staging",
|
|
"BRANCH_PATTERN": "/^dev/",
|
|
"BRANCH_PATTERN_CI": "/^DEV/i",
|
|
"EMPTY_PATTERN": "",
|
|
"PLAIN_PATTERN": "develop",
|
|
}
|
|
return m[key]
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
expr string
|
|
want bool
|
|
}{
|
|
// ── Equality ──────────────────────────────────────────────────────────
|
|
{"eq match", `$CI_COMMIT_BRANCH == "develop"`, true},
|
|
{"eq no match", `$CI_COMMIT_BRANCH == "main"`, false},
|
|
{"eq single-quote", `$CI_COMMIT_BRANCH == 'develop'`, true},
|
|
{"neq match", `$CI_COMMIT_BRANCH != "main"`, true},
|
|
{"neq no match", `$CI_COMMIT_BRANCH != "develop"`, false},
|
|
|
|
// ── Null checks ───────────────────────────────────────────────────────
|
|
{"tag undefined eq null", `$CI_COMMIT_TAG == null`, true},
|
|
{"tag undefined neq null", `$CI_COMMIT_TAG != null`, false},
|
|
{"branch defined neq null", `$CI_COMMIT_BRANCH != null`, true},
|
|
{"branch defined eq null", `$CI_COMMIT_BRANCH == null`, false},
|
|
{"null eq null", `null == null`, true},
|
|
|
|
// ── Variable truthiness (no operator) ────────────────────────────────
|
|
{"truthy branch", `$CI_COMMIT_BRANCH`, true},
|
|
{"falsy tag", `$CI_COMMIT_TAG`, false},
|
|
|
|
// ── Logical NOT ───────────────────────────────────────────────────────
|
|
{"not false", `!$CI_COMMIT_TAG`, true},
|
|
{"not true", `!$CI_COMMIT_BRANCH`, false},
|
|
{"double not", `!!$CI_COMMIT_BRANCH`, true},
|
|
|
|
// ── Boolean AND ───────────────────────────────────────────────────────
|
|
{"and both true", `$CI_COMMIT_BRANCH == "develop" && $CI_PIPELINE_SOURCE == "push"`, true},
|
|
{"and left false", `$CI_COMMIT_BRANCH == "main" && $CI_PIPELINE_SOURCE == "push"`, false},
|
|
{"and right false", `$CI_COMMIT_BRANCH == "develop" && $CI_PIPELINE_SOURCE == "schedule"`, false},
|
|
{"and both false", `$CI_COMMIT_BRANCH == "main" && $CI_PIPELINE_SOURCE == "schedule"`, false},
|
|
|
|
// ── Boolean OR ────────────────────────────────────────────────────────
|
|
{"or both true", `$CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH == "main"`, true},
|
|
{"or left true", `$CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH == "nope"`, true},
|
|
{"or right true", `$CI_COMMIT_BRANCH == "nope" || $CI_COMMIT_BRANCH == "develop"`, true},
|
|
{"or both false", `$CI_COMMIT_BRANCH == "main" || $CI_COMMIT_BRANCH == "nope"`, false},
|
|
|
|
// ── Parentheses ───────────────────────────────────────────────────────
|
|
{"paren or+and", `($CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH == "main") && $CI_COMMIT_TAG == null`, true},
|
|
{"paren or+and false", `($CI_COMMIT_BRANCH == "main" || $CI_COMMIT_BRANCH == "nope") && $CI_COMMIT_TAG == null`, false},
|
|
|
|
// ── Regex match ───────────────────────────────────────────────────────
|
|
{"regex match", `$CI_COMMIT_BRANCH =~ /^dev/`, true},
|
|
{"regex no match", `$CI_COMMIT_BRANCH =~ /^main/`, false},
|
|
{"regex not match", `$CI_COMMIT_BRANCH !~ /^main/`, true},
|
|
{"regex not no match", `$CI_COMMIT_BRANCH !~ /^dev/`, false},
|
|
{"regex case sensitive", `$CI_COMMIT_BRANCH =~ /^DEV/`, false},
|
|
{"regex feat branch", `$CI_COMMIT_BRANCH =~ /^feat\//`, false},
|
|
|
|
// ── Extra whitespace ──────────────────────────────────────────────────
|
|
{"extra spaces", ` $CI_COMMIT_BRANCH == "develop" `, true},
|
|
{"tabs", "$CI_COMMIT_BRANCH\t==\t\"develop\"", true},
|
|
|
|
// ── Multi-line expressions (newlines between tokens) ──────────────────
|
|
{"multiline or true", "$CI_COMMIT_BRANCH == \"develop\" ||\n$CI_COMMIT_TAG != null", true},
|
|
{"multiline or false", "$CI_COMMIT_BRANCH == \"main\" ||\n$CI_COMMIT_TAG != null", false},
|
|
{"multiline and true", "$CI_COMMIT_BRANCH == \"develop\" &&\n$CI_PIPELINE_SOURCE == \"push\"", true},
|
|
{"multiline and false", "$CI_COMMIT_BRANCH == \"main\" &&\n$CI_PIPELINE_SOURCE == \"push\"", false},
|
|
{"multiline with crlf", "$CI_COMMIT_BRANCH == \"develop\" ||\r\n$CI_COMMIT_TAG != null", true},
|
|
|
|
// ── ${VAR} curly-brace syntax ─────────────────────────────────────────
|
|
{"curly var eq match", `${CI_COMMIT_BRANCH} == "develop"`, true},
|
|
{"curly var eq no match", `${CI_COMMIT_BRANCH} == "main"`, false},
|
|
{"curly var truthiness", `${CI_COMMIT_BRANCH}`, true},
|
|
{"curly var falsy", `${CI_COMMIT_TAG}`, false},
|
|
{"curly var neq null", `${CI_COMMIT_BRANCH} != null`, true},
|
|
{"curly mixed", `${CI_COMMIT_BRANCH} == "develop" && $CI_PIPELINE_SOURCE == "push"`, true},
|
|
|
|
// ── Regex flags (/pattern/i etc.) ─────────────────────────────────────
|
|
{"regex flag i match", `$CI_COMMIT_BRANCH =~ /^DEV/i`, true},
|
|
{"regex flag i no match", `$CI_COMMIT_BRANCH =~ /^MAIN/i`, false},
|
|
{"regex flag i not match", `$CI_COMMIT_BRANCH !~ /^MAIN/i`, true},
|
|
{"regex no flag case sensitive", `$CI_COMMIT_BRANCH =~ /^DEV/`, false},
|
|
{"regex flag i version tag", `$CI_PIPELINE_SOURCE =~ /^PUSH$/i`, true},
|
|
|
|
// ── Variable on right side of =~ ──────────────────────────────────────
|
|
{"var regex rhs match", `$CI_COMMIT_BRANCH =~ $BRANCH_PATTERN`, true},
|
|
{"var regex rhs no match", `$CI_PIPELINE_SOURCE =~ $BRANCH_PATTERN`, false},
|
|
{"var regex rhs ci flag match", `$CI_COMMIT_BRANCH =~ $BRANCH_PATTERN_CI`, true},
|
|
{"var regex rhs empty permissive", `$CI_COMMIT_BRANCH =~ $EMPTY_PATTERN`, true},
|
|
{"var regex rhs plain permissive", `$CI_COMMIT_BRANCH =~ $PLAIN_PATTERN`, true},
|
|
{"var regex rhs not match", `$CI_COMMIT_BRANCH !~ $BRANCH_PATTERN`, false},
|
|
|
|
// ── Permissive fallback ───────────────────────────────────────────────
|
|
{"unparseable returns true", `this is not valid syntax %%%`, true},
|
|
{"empty expr returns true", ``, true},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
got := EvalIf(tc.expr, vars)
|
|
if got != tc.want {
|
|
t.Errorf("EvalIf(%q) = %v, want %v", tc.expr, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|